Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moose submodule #87

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add moose submodule #87

merged 1 commit into from
Dec 9, 2022

Conversation

cticenhour
Copy link
Collaborator

Refs #86

@smpeyres smpeyres merged commit 3cf7ac8 into lcpp-org:master Dec 9, 2022
smpeyres added a commit that referenced this pull request Dec 9, 2022
Added command to update and initialize the moose submodule. See commit #87 and issue #86
@smpeyres
Copy link
Collaborator

smpeyres commented Dec 9, 2022

There seem to be some checks that are failing associated with this. Tests ran fine.
@cticenhour You'll probably know something about this...

@smpeyres smpeyres mentioned this pull request Dec 9, 2022
4 tasks
@cticenhour
Copy link
Collaborator Author

Seems GitHub pages thinks it needs to dive all the way down into the submodule to render the README.md file as a webpage.....which is silly. The Jekyll site builder that GitHub Pages uses doesn't like file symlinks, so it fails. I think I can fix this by adding a _config.yml file to CRANE excluding the MOOSE submodule (see here)

@dcurreli before I do this, do you configure your GitHub Pages usage for CRANE at the organization level? Maybe we can exclude there. We don't run into this with Zapdos because we have a gh-pages branch that is independent of the other branches for the Pages deployment to use.

@smpeyres
Copy link
Collaborator

@cticenhour After talking to @dcurreli , he said any webpages that exist for CRANE are old and experimental, and can be removed. I don't know if this is exactly the same as GitHub Pages, but I hope this helped!

@cticenhour
Copy link
Collaborator Author

This seems to be an automated thing - as a gh-pages branch doesn't exist GitHub simply generates one from the README.md file. So really we don't need to do anything - letting it fail for now is fine.

If you decide that you want to have a website generated based on the source code, I have an automatic GitHub action that generates the website for Zapdos using MooseDocs we can talk more about later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants