Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch out all of mem_omega with MetaM [4/?] #233

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

bollu
Copy link
Collaborator

@bollu bollu commented Oct 11, 2024

Description:

This ensures that one part of the infrastructure is written
completely in terms of MetaM. We will give simp_mem the same
treatment next.

PR stacked on top of #232

Testing:

No executable defs have changed, cosim succeeds.

License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

This ensures that one part of the infrastructure is written
completely in terms of MetaM. We will give `simp_mem` the same
treatment next.
@bollu bollu force-pushed the simp-mem-mem-omega-4 branch from 83ababd to 5035e0b Compare October 30, 2024 21:42
@shigoel shigoel merged commit 49914dd into main Oct 31, 2024
5 checks passed
@shigoel shigoel deleted the simp-mem-mem-omega-4 branch October 31, 2024 00:05
shigoel pushed a commit that referenced this pull request Oct 31, 2024
…234)

### Description:

This approach has the advantage of making the code far less noisy.
This prepares it for the refactor where we will pass goal MVarIds
around,
which will increase the amount of noise again 😄 

Stacked on top of #233 

### Testing:

Non functional change, passes conformance.

### License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants