CodeCov security blooper #5631
Open
CodeCov security blooper #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always use package managers. I suppose I might have written this code. Moreover, this Circle CI integration might not even work anymore, I think they have thrown out their 1.0 API. But just to be sure :) See: https://about.codecov.io/security-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should always use package managers. I suppose I might have written this code. Moreover, this Circle CI integration might not even work anymore, I think they have thrown out their 1.0 API.
But just to be sure :)
See:
https://about.codecov.io/security-update
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
This is mainly just to get rid of a mal-practice so it doesn't spread, nothing more. It doesn't even matter if the CI still works. Just remove this horrible line of code and we're good.
This repo isn't affected since the attack was on Jan 31 and no one has been doing builds since.
Issues addressed
n/a
CC: @aronasorman @rtibbles please note the attack and if you are using this in other repos