Skip to content

Commit

Permalink
fix: make progress bars initialise out of view
Browse files Browse the repository at this point in the history
  • Loading branch information
leinelissen committed Jul 25, 2024
1 parent 83b8901 commit 0b13e69
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/components/Progresstrack.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ export function calculateProgressTranslation(
const completion = position / reference;

// GUARD: Check whether the calculated number is valid and not infinite
if (Number.isNaN(completion) || !Number.isFinite(completion)) {
return 0;
if (Number.isNaN(completion) || !Number.isFinite(completion) || !width) {
return -1_000;
}

const output = (1 - completion) * -1 * width;
Expand Down
4 changes: 2 additions & 2 deletions src/screens/Music/overlays/NowPlaying/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ function NowPlaying({ offset = 0, inset }: { offset?: number, inset?: boolean })

const navigation = useNavigation<NavigationProp>();

const bufferAnimation = useRef(new Animated.Value(0));
const progressAnimation = useRef(new Animated.Value(0));
const bufferAnimation = useRef(new Animated.Value(-1_000));
const progressAnimation = useRef(new Animated.Value(-1_000));

const openNowPlayingModal = useCallback(() => {
navigation.navigate('Player');
Expand Down
4 changes: 3 additions & 1 deletion src/screens/modals/Lyrics/components/LyricsProgress.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default function LyricsProgress({
// Calculate the progress animation
const progressAnimation = useDerivedValue(() => {
// GUARD: If the animatino is not active, hide the progress bar
if (!active) return -width.value;
if (!active) return -1_000;

// Calculate how far along we are
const progress = calculateProgressTranslation(position - start, end - start, width.value);
Expand All @@ -65,6 +65,8 @@ export default function LyricsProgress({
};
});

console.log(progressAnimation.value);

// GUARD: Only show durations if they last for more than 5 seconds.
if (duration < 5e7) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/screens/modals/Player/components/ProgressBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ function ProgressBar() {
<ProgressTrack
style={[
styles.themeBackground,
bufferStyles
bufferStyles,
]}
opacity={0.15}
/>
Expand Down

0 comments on commit 0b13e69

Please sign in to comment.