Replace `try_get()` with `get()` in several trait implementations for signals #3569

mahdi739 · 2025-02-09T10:55:32Z

This PR replaces the use of get() with try_get() for retrieving signal values in these trait implementations:

IntoProperty
IntoClass
IntoStyle
Render
RenderHtml
AttributeValue
InnerHtmlValue
This change prevents potential panics when the signal is disposed.
As a result, I've replaced most if let blocks in RenderEffects with match statements to handle different variations of the previous state and the signal value better.
There are some match arms that don't make much sense to me, which usually happens when a signal is disposed, so I just returned None or the previous state if it was possible.

…arena` macro) to prevent panicking if the signal was disposed

… macro) to prevent panicking if the signal was disposed

…if the signal was disposed

…or signals to prevent panicking if the signal was disposed

…Effect::new_with_value`

…king if the signal was disposed

mahdi739 and others added 9 commits February 7, 2025 23:09

Use try_get() in impl IntoProperty for signals (`property_signal_…

451f069

…arena` macro) to prevent panicking if the signal was disposed

Use try_get() in impl IntoProperty for signals (property_signal…

a12ed14

… macro) to prevent panicking if the signal was disposed

Use try_get() in impl IntoClass for signals to prevent panicking …

9f9c6e2

…if the signal was disposed

Use try_get() in impl IntoStyle for signals to prevent panicking …

19fed46

…if the signal was disposed

Use try_get() in impl Render, RenderHtml and AttributeValue f…

f878780

…or signals to prevent panicking if the signal was disposed

add unreachable!() as comment for unreachable match arms in `Render…

f08d550

…Effect::new_with_value`

fix reachable match arms panics as unreachable

9f455df

Use try_get() in impl InnerHtmlValue for signals to prevent panic…

8a9d173

…king if the signal was disposed

[autofix.ci] apply automated fixes

b07973c

Provide feedback