Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.1 #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Ruby 3.1 #63

wants to merge 1 commit into from

Conversation

4e4c52
Copy link

@4e4c52 4e4c52 commented Dec 8, 2022

Why?

The project is currently locked to Ruby 2 despite having no issue with Ruby 3.

What?

Added support for Ruby 3.

t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

t.datetime "archived_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.datetime "created_at", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

t.string "first_name", null: false
t.string "last_name", null: false
t.string "email", null: false
t.integer "company_id"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

t.integer "company_id"
t.string "first_name", null: false
t.string "last_name", null: false
t.string "email", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

t.string "email", null: false
t.integer "company_id"
t.string "first_name", null: false
t.string "last_name", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

t.string "subdomain", null: false
t.string "api_token", null: false
t.string "name", null: false
t.string "subdomain", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

t.string "name", null: false
t.string "subdomain", null: false
t.string "api_token", null: false
t.string "name", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20181206184313) do
ActiveRecord::Schema.define(version: 2018_12_06_184313) do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.

# from scratch. The latter is a flawed and unsustainable approach (the more migrations
# you'll amass, the slower it'll run and the greater likelihood for issues).
# This file is the source Rails uses to define your schema when running `bin/rails
# db:schema:load`. When creating a new database, `bin/rails db:schema:load` tends to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [84/80]

# system, you should be using db:schema:load, not running all the migrations
# from scratch. The latter is a flawed and unsustainable approach (the more migrations
# you'll amass, the slower it'll run and the greater likelihood for issues).
# This file is the source Rails uses to define your schema when running `bin/rails
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [82/80]

@tomekchime
Copy link

@wernull is there any chance this PR will be merged to support Rails 7?

@wernull
Copy link
Member

wernull commented Jun 20, 2023

@tomekchime I think it's safe to consider this project unsupported. I would recommend working from a fork or clone

@aripollak
Copy link

Looks like this was fixed with #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants