Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hint #71

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Fix type hint #71

merged 1 commit into from
Mar 24, 2024

Conversation

shenanigansd
Copy link
Member 

(.venv) PS C:\Users\BradleyReynolds\dev\letsbuilda\imsosorry> pyright
c:\Users\BradleyReynolds\dev\letsbuilda\imsosorry\docs\source\conf.py
  c:\Users\BradleyReynolds\dev\letsbuilda\imsosorry\docs\source\conf.py:59:16 - error: Expression of type "None" cannot be assigned to return type "str"
    "None" is incompatible with "str" (reportReturnType)
  c:\Users\BradleyReynolds\dev\letsbuilda\imsosorry\docs\source\conf.py:61:16 - error: Expression of type "None" cannot be assigned to return type "str"
    "None" is incompatible with "str" (reportReturnType)
2 errors, 0 warnings, 0 informations

@shenanigansd
Fix type hint
5862e8d 
Signed-off-by: Bradley Reynolds <[email protected]>
@shenanigansd shenanigansd self-assigned this Mar 24, 2024
Matiiss
Matiiss approved these changes Mar 24, 2024
View reviewed changes
Copy link

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KRRT7
Copy link

KRRT7 commented Mar 24, 2024

imports within a function, that's a blocker.

@shenanigansd shenanigansd merged commit 3824be6 into main Mar 24, 2024
14 checks passed
@shenanigansd shenanigansd deleted the br/fix-type-hint branch March 24, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matiiss Matiiss Matiiss approved these changes

Assignees

@shenanigansd shenanigansd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenanigansd @KRRT7 @Matiiss