-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CDN] Set override url for CDN hosted files #4881
[CDN] Set override url for CDN hosted files #4881
Conversation
@tonhuisman, I wanted to test this feature but could not find it. Or did i got it all wrong. From my understanding there should now an extra field in /config for this? 🤷♂️ |
Yes, but only for builds that don't have the .js/.css embedded in the .bin file like the MAX builds and Custom builds that have their own CDN url defined (not in the standard build sets, AFAIK) |
At the bottom of // TODO TD-er: Test feature, must remove
/*
#ifdef FEATURE_ALTERNATIVE_CDN_URL
#undef FEATURE_ALTERNATIVE_CDN_URL
#endif
#define FEATURE_ALTERNATIVE_CDN_URL 1
*/ |
Feature:
Set a user-specific url for the .js and .css files, normally hosted at a CDN (Content Delivery Network, jsdelivr.net) or included in the build (
MAX
).customcdnurl.dat
will be removed if setting is empty) (NB: Changed filename from initial commit)TODO:
MAX
builds