Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDN] Set override url for CDN hosted files #4881

Merged
merged 16 commits into from
Nov 27, 2023

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Nov 17, 2023

Feature:

Set a user-specific url for the .js and .css files, normally hosted at a CDN (Content Delivery Network, jsdelivr.net) or included in the build (MAX).

  • Add configuration setting on the Config page (settings file customcdnurl.dat will be removed if setting is empty) (NB: Changed filename from initial commit)
  • Update documentation

TODO:

  • Support in Provisioning feature
  • Update documentation
  • Add support for system variables in Custom CDN url
  • Improve command handling for Provisioning commands
    • Add temporary fall-back to old commands for MAX builds

@TD-er TD-er merged commit 76d1208 into letscontrolit:mega Nov 27, 2023
161 checks passed
@tonhuisman tonhuisman deleted the feature/CDN-set-user-defined-url branch November 27, 2023 15:25
@chromoxdor
Copy link
Contributor

Add configuration setting on the Config page (settings file customcdnurl.dat will be removed if setting is empty) (NB: Changed filename from initial commit)

@tonhuisman, I wanted to test this feature but could not find it. Or did i got it all wrong. From my understanding there should now an extra field in /config for this? 🤷‍♂️

@tonhuisman
Copy link
Contributor Author

Yes, but only for builds that don't have the .js/.css embedded in the .bin file like the MAX builds and Custom builds that have their own CDN url defined (not in the standard build sets, AFAIK)

@TD-er
Copy link
Member

TD-er commented Nov 27, 2023

At the bottom of src/src/CustomBuild/define_plugin_sets.h I have this in comments, which I used for testing myself:

// TODO TD-er: Test feature, must remove
/*
#ifdef FEATURE_ALTERNATIVE_CDN_URL
#undef FEATURE_ALTERNATIVE_CDN_URL
#endif
#define FEATURE_ALTERNATIVE_CDN_URL 1
*/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants