Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Math] Fix double estimation of epsilon in compare functions #5194

Merged
merged 6 commits into from
Dec 28, 2024
Merged

[Math] Fix double estimation of epsilon in compare functions #5194

merged 6 commits into from
Dec 28, 2024

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Dec 24, 2024 •
edited
Loading

Features:

  • Fix unexpected behavior in compare results in rules (epsilon was effectively estimated twice).
  • Adjust epsilon default factor from 1000 to 2.

TODO:

  • Testing, testing, testing

TD-er
TD-er requested changes Dec 27, 2024
View reviewed changes
src/src/Helpers/ESPEasy_math.cpp Outdated Show resolved Hide resolved
@TD-er TD-er merged commit e450177 into letscontrolit:mega Dec 28, 2024
0 of 2 checks passed
@tonhuisman tonhuisman deleted the bugfix/Math-compare-dont-apply-epsilon-estimation-twice branch December 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TD-er TD-er TD-er requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonhuisman @TD-er