[LU9685] Add P178_LU9685 (#5216) #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: letscontrolit#5216 Command example: ``` lu9685servo,<pin>,<angle> ``` To disable pin, set angle to `-1`
TD-er
force-pushed
the
feature/P178_LU9685
branch
from
d251ab7 to
572140a
Compare
tonhuisman
reviewed
Jan 8, 2025
tonhuisman
reviewed
Jan 8, 2025
|
|
||
|
|
||
| # define LU9685_ADDRESS 0x00 // I2C address | ||
| # define LU9685_MAX_ADDRESS 0x3E |
There was a problem hiding this comment.
AFAICS, only 31 (2^5 = 32, minus 0x00) addresses can be configured on the board, the 0x3F notation is the left-shifted address for 0x1F Wire address.
There was a problem hiding this comment.
This was what the user reported to have found with the I2C scan.
So just for now, I have doubled the range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5216
Command example:
To disable pin, set angle to
-1When
<pin>is set to"all", the command applies to all pins.lu9685,setrangecan set a range of pins using a range of system variables.If a variable in a range has not been set, that pin will be disabled.