Remove 'RETURNING' functionality from MultiInserter #7740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
rm-returning
branch
from
ea75cd4 to
ba88f3f
Compare
jprenken
previously approved these changes
Oct 7, 2024
aarongable
requested review from
a team and
beautifulentropy
and removed request for
a team
beautifulentropy
previously approved these changes
Oct 11, 2024
|
Just noting that this feature flag has still not been enabled in prod, and won't be until the new year. |
aarongable
dismissed stale reviews from beautifulentropy and jprenken
via
921e799
|
I've resolved merge conflicts |
|
|
The best kind of merge conflict: no conflict at all, but still a compile error :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the "InsertAuthzsIndividually" feature flag, which has been set to true in both Staging and Production. Delete the code guarded behind that flag being false, namely the ability of the MultiInserter to return the newly-created IDs from all of the rows it has inserted. This behavior is being removed because it is not supported in MySQL / Vitess.
DO NOT MERGE until IN-10737 is complete
Fixes #7718