Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check via zlint if a domain's TLD is valid #7943

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Check via zlint if a domain's TLD is valid #7943

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
086cd68
Check via zlint if a domain's TLD is valid
mcpherrinm Jan 13, 2025
9ac5f5c
Unknown instead of invalid
mcpherrinm Jan 13, 2025
2c3ca81
move check after the empty-suffix handling
mcpherrinm Jan 13, 2025
f5f7613
Change domain uses in High-risk domain test
mcpherrinm Jan 13, 2025
5fdd429
Use HasValidTLD on the full name instead
mcpherrinm Jan 14, 2025
b949278
Revert "Change domain uses in High-risk domain test"
mcpherrinm Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions iana/iana.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ import (
"fmt"

"github.com/weppos/publicsuffix-go/publicsuffix"
zlintutil "github.com/zmap/zlint/v3/util"
)

// ExtractSuffix returns the public suffix of the domain using only the "ICANN"
// section of the Public Suffix List database.
// If the domain does not end in a suffix that belongs to an IANA-assigned
// domain, ExtractSuffix returns an error.
// It confirms with zlint's TLD list.
func ExtractSuffix(name string) (string, error) {
if name == "" {
return "", fmt.Errorf("Blank name argument passed to ExtractSuffix")
Expand All @@ -28,5 +30,9 @@ func ExtractSuffix(name string) (string, error) {
suffix = name
}

if !zlintutil.IsInTLDMap(suffix) {
return "", fmt.Errorf("Domain %s has an unknown TLD %s", name, suffix)
}

return suffix, nil
}
Loading