Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA: Clean up pre-profile order schema and feature flag #7953

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Jan 17, 2025

Deprecate the MultipleCertificateProfiles feature flag, which has been enabled in both Staging and Prod. Delete all code protected by that flag being false, namely the orderModelv1 type and its support code. Update the config schema to match the config-next schema.

IN-10575 tracked the schema change, and IN-10145 tracked the feature flag

Fixes #7324
Fixes #7408

@aarongable aarongable marked this pull request as ready for review January 17, 2025 02:31
@aarongable aarongable requested a review from a team as a code owner January 17, 2025 02:31
Copy link
Contributor

@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

sa/sa.go Outdated Show resolved Hide resolved
@aarongable aarongable merged commit 6b1e7f0 into main Jan 18, 2025
14 checks passed
@aarongable aarongable deleted the rm-ordermodelv1 branch January 18, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove orderModelv1 from the SA package The SA can store a requested profile alongside an order
3 participants