-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add auto tune options #58
Feat/add auto tune options #58
Conversation
@rogerfmglobal thanks for your PR. yes, I started a implementation but I hadn't had the chance to continue it. Thanks for your PR, I'm going to test it and merge it. It doesn't make sense working on another implementation if yours works!! |
Thanks, lgallard. I'll take a look as soon as possible. |
Thanks, I was thinking about a better way to declare these options but
using your implementation!
El El vie, dic. 2, 2022 a la(s) 12:58 p.m., rogerfmglobal <
***@***.***> escribió:
Thanks, lgallard. I'll take a look as soon as possible.
—
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPIJN54BDDPXAVCTTHD7WTWLIMBHANCNFSM6AAAAAASLEZYIA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Ing. Luis Gallardo
https://lgallardo.com
|
…tart_at in variable validation.
Hello, @lgallard, how is it going? Have you had a chance to take a look to the updates? Thanks! |
Hi @lgallard, We are also interested in this PR. Have your reviewed @rogerfmglobal changes? Thanks! |
@xescab I'll be working on this for the next release as soon as possible. Thanks for the head-up!! |
@lgallard, AWS changed recently the way they manage OpenSearch updates: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/service-software.html, see Off-peak windows. I believe this PR does not make sense anymore. Also, the terraform resource has not been updated yet so I'm not asking you for any other change for the moment. Thanks! |
Closing as it does not make sense anymore. |
After i started working on this feature, I saw an issue about this that you are working on: #56
I hope this PR helps you with that or that it can be merged itself.
I tried to follow your code structure and approach.
I tested it (manually) on different scenarios according to the terraform resource definitions: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticsearch_domain