Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add auto tune options #58

Closed

Conversation

rogerfmglobal
Copy link

After i started working on this feature, I saw an issue about this that you are working on: #56

I hope this PR helps you with that or that it can be merged itself.

I tried to follow your code structure and approach.

I tested it (manually) on different scenarios according to the terraform resource definitions: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticsearch_domain

@rogerfmglobal rogerfmglobal marked this pull request as ready for review November 25, 2022 10:03
@lgallard
Copy link
Owner

@rogerfmglobal thanks for your PR. yes, I started a implementation but I hadn't had the chance to continue it. Thanks for your PR, I'm going to test it and merge it. It doesn't make sense working on another implementation if yours works!!

variables.tf Outdated Show resolved Hide resolved
@rogerfmglobal
Copy link
Author

Thanks, lgallard. I'll take a look as soon as possible.

@lgallard
Copy link
Owner

lgallard commented Dec 2, 2022 via email

@rogerfmglobal
Copy link
Author

Hello, @lgallard, how is it going? Have you had a chance to take a look to the updates?

Thanks!

@xescab
Copy link

xescab commented Mar 2, 2023

Hi @lgallard,

We are also interested in this PR. Have your reviewed @rogerfmglobal changes?

Thanks!

@lgallard
Copy link
Owner

lgallard commented Mar 9, 2023

@xescab I'll be working on this for the next release as soon as possible. Thanks for the head-up!!

@rogerfmglobal
Copy link
Author

rogerfmglobal commented Mar 31, 2023

@lgallard, AWS changed recently the way they manage OpenSearch updates: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/service-software.html, see Off-peak windows.

I believe this PR does not make sense anymore.

Also, the terraform resource has not been updated yet so I'm not asking you for any other change for the moment.

Thanks!

@lgallard
Copy link
Owner

Closing as it does not make sense anymore.

@lgallard lgallard closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants