Add RemoteCallbacks.push_transfer_progress #1345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing callback
RemoteCallbacks.transfer_progress
is only called during fetches, not pushes.This PR exposes libgit2's
push_transfer_progress
callback, allowing users to:Note: I had to rewrite test_push_options to use a real RemoteCallbacks object instead of a mock object (the mock wasn't complete enough to work with my additions to git_push_options)