add cron to dcron and splite e2e test cases from other test cases. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add NodeID function into dcron * add cron lib * fix warning * logger removal : phares1 * update * update * update
* add example app to readme * add NodeID function into dcron * add cron lib * fix warning * logger removal : phares1 * update * update * update * update * update * update * update * update test workflow * revert 1.22 * update etcd driver * update * fix get nodes * update * update for fix TAT * Revert "update etcd driver" This reverts commit a21ebf7. * Revert "deps: updated go-redis to v9 (#79)" This reverts commit 0b85b24. * update * update * refact etcd * Revert "refact etcd" This reverts commit 049bed1. * Revert "update" This reverts commit 9c71fd6. * update * refactor etcddriver * fix error * update * Revert "update" This reverts commit 6cfcfe6. * Revert "fix error" This reverts commit 99b2d82. * Revert "refactor etcddriver" This reverts commit a576ac3. * update * update * remove comments, and fix * add comments
dxyinme
changed the title
|
etcd driver 之前的heartbeat写的有点问题，也修复了。 |
|
👍👍 我这两天就看看 |
|
这个合并以后也是直接作为broken版本 要不要搞一个v2 然后入口函数直接重构 |
感觉不是很需要作为broken版本，因为API啥的都没什么变化。搞个V2也可以，不过我觉得可以等到把cron的那些什么Entities(), GetJob()之类的函数移植过来之后再弄 |
|
好吧 那就先合并主版本吧 |
|
|
好的 |
|
测试脚本可能需要改下， 我看你加上了 e2e 测试，看看生成的coverage用哪个呀 还是能两个都可以用。 |
这个我研究一下，看看能不能把他们合并在一起 |
我还是把他们合在一起了，单纯e2e的话生成的coverage是空的，而且也会丢失很多覆盖率。 |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
OK搞定了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.