Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yamux] Limit the send buffer size per stream #314

Closed
wants to merge 6 commits into from
Closed

[Yamux] Limit the send buffer size per stream #314

wants to merge 6 commits into from

Conversation

StefanBratanov
Copy link
Collaborator

@StefanBratanov StefanBratanov commented Sep 8, 2023 •
edited
Loading

Before we were limiting the sending buffer for the whole connection. I had a look in rust implementation and it looks like their implementation is limiting it per stream https://github.com/libp2p/rust-yamux/blob/master/yamux/src/lib.rs .This change could help with #311

  • Changed currently configured MAX_BUFFER_SIZE to be per stream
  • Renamed sendBlocks to sendFrames

@StefanBratanov StefanBratanov marked this pull request as draft September 8, 2023 12:48
@StefanBratanov
Copy link
Collaborator Author

Closing this. Will increase the buffer size per connection instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StefanBratanov