-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic module addition #488
base: main
Are you sure you want to change the base?
quic module addition #488
Conversation
Hi @seetadev! Thanks for this. A couple things right off.
I haven't gotten a chance to actually play with the code, but will do so. Are you familiar with the |
@pacrob: Hi Paul. Thank you so much for the detailed feedback — really appreciate it! Please find my comments below each feedback point.
I really appreciate the thorough review and constructive feedback. Looking forward to getting these changes in place. Will update soon. Thank you so much once again! 😊🚀 |
Hey, @seetadev , I'm so sorry about the delay here. I need to remember that CI doesn't run unless I trigger it. I added a newsfragment and ran CI and it looks like some errors are popping up. You can run linting manually locally with
and your test file directly with
|
@pacrob : Hi Paul. Thank you so much for reviewing the pull request and taking the time to run the CI—no worries about the delay, I completely understand how busy things can get! I really appreciate your guidance here. I'll go ahead and:
I’ll update the PR shortly with the fixes and let you know once everything is ready for another review. Thanks again for your patience and for pointing me in the right direction—it means a lot! Please feel free to share any additional feedback or suggestions to ensure the PR aligns perfectly with project standards. Looking forward to your thoughts once I push the updates! 😊 |
Title: Add QUIC Module Support to py-libp2p
Description:
This PR introduces support for the QUIC transport protocol in py-libp2p. QUIC is a modern, low-latency transport protocol that offers advantages like connection migration, multiplexing without head-of-line blocking, and improved security via TLS 1.3. Adding QUIC support enhances the performance, reliability, and compatibility of py-libp2p with other implementations in the libp2p ecosystem.
Key Changes:
New QUIC Module:
quic_transport
module for handling QUIC-based connections.Dependencies:
aioquic
library for QUIC protocol support.requirements.txt
with the necessary dependencies.Integration with Existing Components:
TransportManager
to register QUIC as an available transport.Configuration Options:
Testing:
go-libp2p
andjs-libp2p
QUIC implementations.Documentation:
README.md
and transport documentation to include details on using QUIC.examples/
.Why This Matters:
py-libp2p
with the latest advancements ingo-libp2p
andjs-libp2p
, ensuring smoother cross-implementation interoperability.Next Steps:
Related Issues:
Closes (#463)
Checklist: