fix: FixedBitString might work as expected #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicceboy
force-pushed
the
fix-fixed-size-bitstring
branch
from
1f51630 to
0c708b6
Compare
XAMPPRocky
reviewed
Nov 28, 2024
I want to clarify that, that is a possibility. If we need to wrap types to provide a better interface we can and should do that. This is totally fine for now though. |
Nicceboy
force-pushed
the
fix-fixed-size-bitstring
branch
from
0c708b6 to
ef9b68f
Compare
|
I'll link #76 if it can be then improved at the same time. |
Merged
|
What if we would just use type |
This was referenced Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartiallyFixes #383
I am not sure if the current way is the most convenient way to use the type, but without wrapping it with newtype, I will not get much better.