fix(player): save watch position on playback end #7061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Feb 1, 2025
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt
Outdated
Show resolved
Hide resolved
FineFindus
force-pushed
the
fix/save-watch-position-on-playback-end
branch
from
0051e88 to
23d89b9
Compare
Bnyro
reviewed
Feb 3, 2025
app/src/main/java/com/github/libretube/services/AbstractPlayerService.kt
Outdated
Show resolved
Hide resolved
This fixes an issue, where the watch position would not correctly be saved as the fully watched video. This could occur when the last part of a video was skipped by a sponsorblock segment.
FineFindus
force-pushed
the
fix/save-watch-position-on-playback-end
branch
from
23d89b9 to
2a2ad88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue, where the watch position would not correctly be saved as the fully watched video. This could occur when the last part of a video was skipped by a SponsorBlock segment.