SDL3_mixer/Mix_SetPosition: Remove comment regarding inconsistent API #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may be wrong, but seems that removed inconsistency comment is no longer relevant - a quick look on https://github.com/libsdl-org/SDL_mixer/blob/02b36f2c4b3a25b5096be3bb32b127f63d948ca6/src/effect_position.c#L1719 gives me feeling that now true and false are returned instead of 0 / 1, and one now represents a success code. |
|
You are correct, thanks for noticing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edit was made by @MrOnlineCoder.
Live page is here: https://wiki.libsdl.org/SDL3_mixer/Mix_SetPosition
If this user should be blocked from further edits, an admin should go to https://wiki.libsdl.org/MrOnlineCoder/block
If this user should be trusted to make direct pushes to main, without a pull request, an admin should go to https://wiki.libsdl.org/MrOnlineCoder/trust
WHETHER YOU MERGE OR REJECT THIS PULL REQUEST, DON'T FORGET TO DELETE THE BRANCH. Otherwise, MrOnlineCoder won't be able to start a new PR for this page.