Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add true streaming #90

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rolandlo
Copy link
Collaborator

@rolandlo rolandlo commented Dec 23, 2024

Tests are still missing.

The script example/target.lua works with luajit and Lua 5.1, 5.2 and 5.3, but crashes with Lua 5.4 due to illegal machine instruction.

@rolandlo rolandlo marked this pull request as draft December 23, 2024 21:19
Tests are still missing.
It works with luajit, but produces slightly wrong images with Lua 5.2, 5.3 and crashes with Lua 5.4
@jcupitt
Copy link
Member

jcupitt commented Dec 24, 2024

This is very cool!

The custom source / target classes would need the g_signal_connect() etc. mechanism to be wrapped and this is significantly harder because of callbacks, GC integration, and marshaling.

Signals are handy for other stuff --- pyvips exposes the progress signals, so you can have on_eval() etc. handlers which tick down during evaluation. They are useful for desktop or CLI programs but probably less so on servers heh.

@rolandlo rolandlo changed the title WIP: Add true streaming (initial commit) WIP: Add true streaming Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants