-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid PHP 8.3 FFI deprecations (fixes #226) #231
Avoid PHP 8.3 FFI deprecations (fixes #226) #231
Conversation
@jcupitt can this be merged soon? :) |
Sorry! I'll spend some time on this later today. |
This looks good, and you say, nice and simple. We just need to fix the unit test failure with php 8.3. I'm not sure what's causing the stack overflow and I don't have php8.3 installed or I'd investigate myself :( |
I saw that on my mac and thought it was just a mac fluke. I'll investigate it myself, no problem. |
Looking for merging this... |
The salient part of the unit test failure is:
https://github.com/libvips/php-vips/actions/runs/7758073643/job/21184045945#step:6:42 I assume it's due to the use of |
Let's merge and do any final tweaks in a followup. Thanks for doing this work, and sorry for being so slow :( |
i have some problem like that : |
@Tak-Pesar, this is a PHP bug, you need to disable stack size checking, have a look at the php-vips README. |
This probably isn't the ideal way (the ideal way would be dependency injection), but it's fast and backward-compatible.
I tested this briefly on my machine and it seemed to work well.