-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deploy script to include SepoliaDepositAdapter contract upgrade #824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Scarcely am I sure if we need to hardcode the addresses here instead of putting/reading them from the deployed-sepolia.json
wdyt, @arwer13?
@TheDZhon @vp42ldo There is |
There is an issue with |
Oh, we've forgotten to add it to the state file :/ I'd propose to add it now under |
Having it would be prudent, I agree with @arwer13 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, taking into account the deploy script is most likely one-time-usage and the migration to the new core repo and typescript (won't move it there)
Update deploy script to include SepoliaDepositAdapter contract upgrade