This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Completed the port to C# #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status of this pull request? Are there any plans to merge it? |
|
Hi Strachu, I apologize for the delay. Reviewing this PR has been on my backburner to-do list. I'll try to get around do it shortly. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finished previous, incomplete port of client code for C#.
It's mainly direct translation of java code with usage of currently available C# parts. The exception to it is the ContextMenu module, where I've merged the code for all platforms, because it was functionally identical for all platforms.
I've tried to maintain a consistency in style with existing C# code.
I've tested this port on both Windows 8.1 64-bit and Windows 7 64-bit.