Add lease acquisition recovery interval configurability #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1346 1346
Branches 185 184 -1
=========================================
Hits 1346 1346
Continue to review full report at Codecov.
|
duinness
changed the title
|
Here is the issue to which this PR should be linked Doesn't look like I have permission to link them... or else I'm doing something wrong, which is a strong possibility 🙂 |
jennyEckstein
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to modify the acquisition recovery interval because when you have a large number of streams on one account trying to recover every 5 seconds can get you stuck in a rate-limit loop.
My test environment has ~100 kinesis streams being managed by 10 instances of lifion-kinesis.
After patching my lifion-kinesis with this change and setting the leaseAquisitionRecoveryInterval to 30 seconds, errors in the environment related to this went from ~5000/min to ~20/min.