-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simCLR with temperature schedule #1413
Add simCLR with temperature schedule #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot of the PR!
Could you add a test_cosine_schedule__period
method to the tests in tests/utils/test_scheduler.py
to check that the new functionality works as expected?
Thanks a lot for the feedback! I will take a look at the benchmark next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the update! This looks pretty much good to merge. Left one small question.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 130 130
Lines 5476 5484 +8
=======================================
+ Hits 4675 4682 +7
- Misses 801 802 +1
☔ View full report in Codecov by Sentry. |
Hello there! I stumbled upon this and was wondering, has there been any docs added to document the use of the temperature scheduler with NTXentLoss for simCLR? |
Hi,
this is my first PR to an open source project so I am starting it out as a draft.
I am looking to contribute to #1319. This PR should cover the first task. I will probably be able to do most of the tasks except for actually running the benchmark, since I don't think I have the neccessary hardware.
Thanks for reviewing :)