Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust pagination to be defensive at 2500 entries #1786

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

japrescott
Copy link
Contributor

closes lig-6096

  • adjust pagination to be defensive 2500 entires to not go over 32MB limit.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (cde2bac) to head (86bf137).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1786   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         163      163           
  Lines        6833     6833           
=======================================
  Hits         5825     5825           
  Misses       1008     1008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@japrescott japrescott merged commit 05138d6 into master Jan 28, 2025
14 checks passed
@japrescott japrescott deleted the fix-export-pagination branch January 28, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants