Add max_total_routing_fee_msat for pay_invoice #2719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In lightningdevkit#2417 support for setting a max fee was added but it is not exposed when using the `pay_invoice` utility functions. This makes it so the user can pass in that parameter. One downside is that this removes the defualt value form before.
benthecarman
force-pushed
the
max-fee-pay-invoice
branch
from
d0ab612 to
9f7733f
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
==========================================
+ Coverage 88.75% 88.80% +0.05%
==========================================
Files 112 113 +1
Lines 88504 89172 +668
Branches 88504 89172 +668
==========================================
+ Hits 78548 79186 +638
- Misses 7717 7742 +25
- Partials 2239 2244 +5
☔ View full report in Codecov by Sentry. |
|
Mh, let's first discuss options and decide on a course of action in #2718 before we go ahead including it in the API like this. If we want to do it, we also may want to see if we want to more generally provide a way to override default route/payment parameters. |
|
How about #2727 instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2417 support for setting a max fee was added but it is not exposed when using the
pay_invoiceutility functions. This makes it so the user can pass in that parameter. One downside is that this removes the default value form before.If we want to keep the default there aren't many pretty options (either making
pay_invoice_with_max_feeor having the param beOption<Option<u64>>) so I thought it'd be easier to just remove the default.Also does a small cleanup I found