Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential cases where max_dust_htlc_exposure_msat overflows #2722

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

benthecarman
Copy link
Contributor

These are the few cases I found that max_dust_htlc_exposure_msat could be overflowing, there could be more

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3e7aac) 88.75% compared to head (55da9c4) 88.74%.
Report is 35 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.01%     
==========================================
  Files         112      113       +1     
  Lines       88504    89170     +666     
  Branches    88504    89170     +666     
==========================================
+ Hits        78548    79138     +590     
- Misses       7717     7785      +68     
- Partials     2239     2247       +8     
Files Coverage Δ
lightning/src/ln/channel.rs 88.66% <100.00%> (+0.26%) ⬆️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing complicated here, updates the only place where FeeRateMultiplier is used in the codebase (outside of tests), and updates all the places where get_max_dust_htlc_exposure_msat returning max_value is problematic. No reason to wait on another reviewer.

@TheBlueMatt TheBlueMatt merged commit 9854477 into lightningdevkit:main Nov 12, 2023
@benthecarman benthecarman deleted the dust-overflow branch November 12, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small payments not going through on mainnet
3 participants