frdrpcserver: update rpcserver-max-recv-size #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, wanted to follow up on this PR to help us with our node audit reporting. While this is a temporary workaround, it's necessary for now until we can implement pagination calls. Please let me know if there's anything further needed to move this forward. |
|
Can you please squash the existing commits into one and then add one that updates the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Change(s):
The change for this PR increases the gRPC message size limit from 600MiB to 800MiB. Similar to the PR above, we encountered a ResourceExhausted error while running the NodeAudit report, particularly on nodes with a high number of on-chain transactions.
This error could be due to the gRPC message size exceeding the current 600MiB limit. In LND, this limit is configurable and can be adjusted by the calling client, but Faraday currently lacks this configurability. This is a temporary fix, with issue 177 recommending a long-term solution involving the implementation of pagination for the calls.
The gRPC message size limit is being increased to 800 MiB to accommodate large payloads generated by specific use cases, such as transaction histories or detailed audit reports. Trying to strike a balance between supporting current operational needs and maintaining resource efficiency.