multi: Bump go to 1.22.6 & litd to v0.14.0-alpha
#109
+482
−487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorTigerstrom
force-pushed
the
litd-v0_14_0
branch
2 times, most recently
from
a74cbc4 to
fee1bac
Compare
jamaljsr
reviewed
Jan 17, 2025
ViktorTigerstrom
force-pushed
the
litd-v0_14_0
branch
from
98aab99 to
138cf42
Compare
In /mobile we replace faraday to force it to be set to v0.2.13-alpha, as we'll else get an ambiguous import during `make mobile` of which faraday/frdrpc to use. This forces the dependency to the faraday/frdrpc of the faraday v0.2.13-alpha release, where as the litcli dependency uses the first actual separate tagged release for frdrpc v0.1.0
ViktorTigerstrom
force-pushed
the
litd-v0_14_0
branch
from
5608d9f to
8560754
Compare
Comment on lines
+212
to
+216
| // Force faraday to use the master version as we'll either get an ambigious import if we try use faraday v0.2.13-alpha | ||
| // as an indirect import here instead of indirectly importing faraday/frdrpc v1.0.0, or get an unkown revision for the | ||
| // frdrpc if we don't include this replace. Once faraday v0.2.14-alpha is released, this should be resolved and this | ||
| // replace can be removed in favour of importing that. | ||
| replace github.com/lightninglabs/faraday => github.com/lightninglabs/faraday v0.2.13-alpha.0.20241118202659-a3aba5b7ea49 |
There was a problem hiding this comment.
Had to include this replace which isn't ideal, especially since it's referencing the unreleased master version, but couldn't figure any other way of getting the dependencies to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the lightning-terminal dependency for the wasm-client + mobile to
v0.14.0-alpha. It also bumps the go version of the lightning-node-connect package to1.22.6.We also bump the
upload-artifactaction to v4