Add support for new TAP channel RPCs #38
Open
+10,926
−674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamaljsr
force-pushed
the
0-19-staging
branch
2 times, most recently
from
ce854ee to
88d4534
Compare
jamaljsr
force-pushed
the
0-19-staging
branch
from
88d4534 to
952b0da
Compare
jamaljsr
changed the title
ViktorTigerstrom
approved these changes
Jan 16, 2025
| @@ -5,12 +5,12 @@ | |||
| "main": "./dist/index.js", | |||
| "types": "./dist/index.d.ts", | |||
| "config": { | |||
| "lnd_release_tag": "v0.18.2-beta", | |||
| "lnd_release_tag": "v0.18.4-beta", | |||
| "loop_release_tag": "v0.28.5-beta", | |||
There was a problem hiding this comment.
Should we also bump this to v0.29.0-beta to match LNC?
Yes, I would wait for a tagged release of LNC, then bump the version numbers to match, before merging this PR. Apologies, I probably should have waited before requesting review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the generated types to include the new RPCs added to support TAP channels and asset payments in
litdv0.14.0-alpha.Depends on
lightning-node-connectlightning-terminal-v0.14.0 branch being merged