[1/?] Static Loop-In Address - Create #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
hieblmi
force-pushed
the
static-addr-1
branch
2 times, most recently
from
9818ae1 to
d28f6b7
Compare
hieblmi
commented
Oct 18, 2023
hieblmi
force-pushed
the
static-addr-1
branch
from
d28f6b7 to
00e42c6
Compare
hieblmi
commented
Oct 18, 2023
hieblmi
changed the title
hieblmi
force-pushed
the
static-addr-1
branch
2 times, most recently
from
a6ed4ed to
85a284b
Compare
hieblmi
commented
Oct 18, 2023
hieblmi
force-pushed
the
static-addr-1
branch
from
85a284b to
f639abc
Compare
hieblmi
commented
Oct 20, 2023
hieblmi
force-pushed
the
static-addr-1
branch
2 times, most recently
from
0bfc4c4 to
2bfc438
Compare
hieblmi
changed the title
hieblmi
force-pushed
the
static-addr-1
branch
from
2bfc438 to
a6e9b60
Compare
bhandras
reviewed
Oct 31, 2023
hieblmi
force-pushed
the
static-addr-1
branch
from
a6e9b60 to
5cce8dc
Compare
hieblmi
commented
Nov 3, 2023
hieblmi
commented
Nov 3, 2023
hieblmi
force-pushed
the
static-addr-1
branch
3 times, most recently
from
d62812f to
4081190
Compare
hieblmi
force-pushed
the
static-addr-1
branch
from
fbc2861 to
bd53ae5
Compare
hieblmi
force-pushed
the
static-addr-1
branch
from
bd53ae5 to
3d3fe49
Compare
bhandras
approved these changes
Feb 14, 2024
hieblmi
force-pushed
the
static-addr-1
branch
from
3d3fe49 to
8a19ac9
Compare
|
@sputn1ck: review reminder |
sputn1ck
reviewed
Feb 26, 2024
sputn1ck
reviewed
Feb 26, 2024
swapserverrpc/server.proto
Outdated
|
|
||
| message ServerAddressParameters { | ||
| // A unique identifier for static address parameters assigned by the server. | ||
| bytes id = 1; |
There was a problem hiding this comment.
I don't think a unique identifier is needed. Both server and client can just use the pkscript
There was a problem hiding this comment.
I thought this might be handy once we enable multple static addresses per client?
There was a problem hiding this comment.
They will also have a unique scriptkey, as both parties should not reuse keys.
| // NewAddress starts a new address creation flow. | ||
| func (m *Manager) NewAddress(ctx context.Context) (*AddressParameters, | ||
| error) { | ||
|
|
There was a problem hiding this comment.
Doesn't it make sense to fetch an existing address first and return this? As we're not supporting multiple addresses we can have this first check here. I think on the cli it would make sense to just return the current address if you run loopcli s new
hieblmi
force-pushed
the
static-addr-1
branch
4 times, most recently
from
2723522 to
4570bfd
Compare
sputn1ck
approved these changes
Feb 26, 2024
hieblmi
force-pushed
the
static-addr-1
branch
from
4570bfd to
4d2ae0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR implements static address generation for loop-ins.
It includes new command line options for
loop, namely~$ loop in static newa.k.a~$ loop in s n.Missing features to consider this PR complete are: