Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: Asset Minting with V1 Asset Group Key and Chantools Cold Storage Support #1272

Merged
merged 27 commits into from
Jan 16, 2025
Merged

Part 1: Asset Minting with V1 Asset Group Key and Chantools Cold Storage Support #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b96c9ff
multi: fix formatting and doc comments
ffranr Jan 3, 2025
749ee1c
asset: add GroupKeyRevealTapscript.Root method
ffranr Jan 8, 2025
aec207c
tapgarden: introduce FundBatchResp return type for FundBatch
ffranr Jan 6, 2025
bdd1228
tapgarden: add new function newVerboseBatch
ffranr Jan 6, 2025
fb1c2f6
tapgarden: clarify buildGroupReqs with additional comments
ffranr Jan 8, 2025
934798c
docs: add guide for using external group keys
ffranr Jan 7, 2025
ee592c2
multi: update FundBatch RPC to return verbose batch
ffranr Jan 6, 2025
5ca8c06
rpc: add ExternalKey message type and integrate with MintAsset
ffranr Jan 8, 2025
2d07b0a
asset+tapgarden: add ExternalKey field to Seedling and GroupKeyRequest
ffranr Jan 9, 2025
5921d2b
rpcserver: unmarshal Asset.ExternalGroupKey in MintAsset endpoint
ffranr Jan 9, 2025
f8085e3
taprpc: add external_key field to GroupKeyRequest message
ffranr Jan 9, 2025
ef125f5
cmd/tapcli: add minting flags for external key asset group support
guggero Dec 27, 2024
881ed42
mintrpc: update doc comment for MintAsset.group_tapscript_root field
ffranr Jan 8, 2025
f7fce5e
asset+tapgarden: add CustomTapscriptRoot to GroupKey and GroupKeyRequest
ffranr Jan 8, 2025
14333ab
asset: add versioning to GroupKey and GroupKeyRequest
ffranr Jan 8, 2025
a2aa3e9
asset: add support for V1 group keys in GroupKeyRequest methods
ffranr Jan 7, 2025
1f3dd7f
rpc+tapgarden: FundBatch and ListBatches return unsealed PSBTs
ffranr Nov 22, 2024
ebbc68b
sqlc: add columns version and custom_subtree_root_id to asset_groups
ffranr Jan 8, 2025
5d47774
tapdb: write new GroupKey fields to database rows
ffranr Jan 8, 2025
015fc04
tapdb: read new GroupKey fields from database rows
ffranr Jan 8, 2025
5532602
proof: support group key reveal V1 in mint proof generation
ffranr Jan 8, 2025
777cc5e
itest: verify group virtual transaction can be derived from PSBT
ffranr Nov 22, 2024
09e24f7
Makefile: enhance `build-itest` target for chantools setup
ffranr Jan 9, 2025
e0dba5b
itest: add harness for invoking chantools binary
ffranr Jan 6, 2025
032061e
itest: add test for minting with external group key via chantools
ffranr Jan 6, 2025
334a73b
unittests+mock: add missing args to NewGroupKeyRequestNoErr
ffranr Jan 15, 2025
5ca4168
tapdb: add unit test for asset group version 1
ffranr Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ cmd/tapd/tapd

/itest/lnd-itest
/itest/btcd-itest
/itest/chantools
/itest/regtest/*
/itest/*.log
/itest/.backendlogs/*
Expand Down
9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ build:
$(GOBUILD) -tags="$(DEV_TAGS)" -o tapcli-debug $(DEV_GCFLAGS) $(DEV_LDFLAGS) $(PKG)/cmd/tapcli

build-itest:
@if ! command -v chantools > /dev/null; then \
$(call print, "Building itest chantools."); \
rm -rf itest/chantools; \
git clone --depth 1 --branch v0.13.5 https://github.com/lightninglabs/chantools.git itest/chantools; \
cd itest/chantools && make install; \
else \
$(call print, "Chantools is already installed and available in PATH."); \
fi

@$(call print, "Building itest btcd.")
CGO_ENABLED=0 $(GOBUILD) -tags="integration" -o itest/btcd-itest $(BTCD_PKG)

Expand Down
Loading
Loading