Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: export collector timeout as prometheus config #1300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GeorgeTsagk
Copy link
Member

@GeorgeTsagk GeorgeTsagk commented Jan 14, 2025

This PR exports the prometheus collector timeout as a prometheus config parameter.

With this timeout we will be able to observe values on our loadtest tapds for longer periods, as the timeout will be harder to reach.

@GeorgeTsagk GeorgeTsagk self-assigned this Jan 14, 2025
@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12808537908

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 4 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 40.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
monitoring/asset_balances_collector.go 0 1 0.0%
monitoring/asset_collector.go 0 1 0.0%
monitoring/db_collector.go 0 1 0.0%
monitoring/prometheus.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
commitment/tap.go 2 84.32%
universe/interface.go 4 51.95%
tapgarden/caretaker.go 4 68.87%
Totals Coverage Status
Change from base Build 12791730946: 0.04%
Covered Lines: 26421
Relevant Lines: 64514

💛 - Coveralls

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we make this a config option? This needs to be set with the scape timeout in mind. Otherwise, it's possible that scrapes just continue to build up if the interval is << the scrape latency.

@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch from d734487 to 6c6bb3c Compare January 16, 2025 11:48
@GeorgeTsagk GeorgeTsagk changed the title monitoring: bump default metrics collection timeout to 120s monitoring: export collector timeout as prometheus config Jan 16, 2025
@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch 2 times, most recently from c699654 to 3649bac Compare January 16, 2025 12:02
@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch from 3649bac to 1f94bd4 Compare January 16, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

4 participants