Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minting on Ledger signing device #1301

Open
wants to merge 4 commits into
base: sealbatch-signed-group-psbt
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented Jan 16, 2025

Depends on #1290.
Depends on #1295.

Adds the necessary meta information to the group key VM transaction PSBT to allow signing of such a mint authorization transaction using a custom version of the HWI library and a Ledger signing device.

A new guide documents the required steps.

@guggero guggero requested review from Roasbeef and ffranr January 16, 2025 18:45
@coveralls
Copy link

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12833451443

Details

  • 33 of 134 (24.63%) changed or added relevant lines in 1 file are covered.
  • 58 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.09%) to 40.742%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tapgarden/planter.go 33 134 24.63%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapchannel/aux_leaf_signer.go 2 43.08%
fn/option.go 3 43.3%
tapgarden/planter.go 4 65.02%
commitment/tap.go 4 83.86%
tapchannel/aux_invoice_manager.go 6 83.25%
tapdb/multiverse.go 6 68.21%
asset/asset.go 8 76.9%
universe/interface.go 10 52.81%
asset/mock.go 13 91.25%
Totals Coverage Status
Change from base Build 12831178104: -0.09%
Covered Lines: 26641
Relevant Lines: 65390

💛 - Coveralls

Base automatically changed from pederson-group-key to main January 17, 2025 08:10
@guggero guggero force-pushed the cold-group-key-pedersen branch from 8010b8e to 826920d Compare January 17, 2025 08:27
@guggero guggero force-pushed the cold-group-key-pedersen branch from 826920d to bc4ee59 Compare January 17, 2025 16:58
@guggero guggero changed the base branch from main to sealbatch-signed-group-psbt January 17, 2025 16:58
@guggero
Copy link
Member Author

guggero commented Jan 17, 2025

Changed the base branch to sealbatch-signed-group-psbt (#1295) since that gives us the nicer user experience and simplifies the signing guide for the Ledger as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants