Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-ci: bump upload-artifact@v3 to @v4 #1303

Merged
merged 1 commit into from
Jan 17, 2025
Merged

github-ci: bump upload-artifact@v3 to @v4 #1303

merged 1 commit into from
Jan 17, 2025

Conversation

GeorgeTsagk
Copy link
Member

Description

Bumps the github workflow action upload-artifact from v3 to v4
(Migration Doc)

@GeorgeTsagk GeorgeTsagk self-assigned this Jan 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12816509762

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 32 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 40.734%
Files with Coverage Reduction New Missed Lines %
internal/test/helpers.go 2 86.95%
tapchannel/aux_leaf_signer.go 3 43.08%
commitment/tap.go 5 83.64%
tapgarden/caretaker.go 7 68.21%
universe/interface.go 15 50.65%
Totals Coverage Status
Change from base Build 12810137371: -0.01%
Covered Lines: 26535
Relevant Lines: 65142
💛 - Coveralls

@GeorgeTsagk GeorgeTsagk requested review from guggero and ffranr January 16, 2025 20:13
ffranr
ffranr approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ffranr ffranr enabled auto-merge January 16, 2025 22:11
@ffranr ffranr requested a review from dstadulis January 16, 2025 22:11
@ffranr ffranr added this pull request to the merge queue Jan 17, 2025
@guggero guggero removed this pull request from the merge queue due to a manual request Jan 17, 2025
@guggero guggero merged commit ffef906 into lightninglabs:main Jan 17, 2025
18 checks passed
@guggero guggero mentioned this pull request Jan 17, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffranr ffranr ffranr approved these changes

@guggero guggero guggero approved these changes

@dstadulis dstadulis Awaiting requested review from dstadulis

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeorgeTsagk @coveralls @guggero @ffranr