Lock Minting Anchor TX Change Output for Future Universe Commitment Support #1325
+368
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12990933517Details
💛 - Coveralls |
Introduce MintingBatch.AddSeedling, a method for attempting to add seedlings to a batch. Future commits will extend this method with validation logic to ensure compatibility of the seedling with others already in the batch.
This commit adds a new flag to the `MintAsset` RPC request message. When set to true, this flag enables the universe commitment feature for the minting batch. To comply with this feature, the minting batch must be restricted to assets that share the same group key. Universe commitments are minter-controlled, on-chain anchored attestations regarding the state of the universe.
Add the EnableUniCommitment field to the seedling structure. This field is populated based on data from the corresponding RPC request.
Add the EnableUniCommitment field to the MintingBatch structure, populating it when a seedling is added to the batch. Include validation logic to ensure that for a batch with uni commitment enabled, all seedlings share the same asset group key.
ffranr
force-pushed
the
unit-commitment-mint-output
branch
from
8c10bbc to
a18c17e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress draft that will eventually address Minimal Code Changes for Future Universe Commitment Transaction Support.
At a high level, this PR introduces the following functionality: if the "enable universe commitment" flag is set on a batch, the change output will be locked with a script that only
tapdcan spend. Additionally, the PR includes validations and restrictions to ensure that the "enable universe commitment" feature can only be applied to minting batches containing assets from the same asset group. For more details, refer to the linked issue.