Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #1329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lencap
Copy link

@lencap lencap commented Jan 27, 2025

No description provided.

@ffranr
Copy link
Contributor

ffranr commented Jan 27, 2025

Thank for the PR.

Line length linter might fail.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12993866245

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.729%

Files with Coverage Reduction New Missed Lines %
tapgarden/planter.go 2 64.98%
tapchannel/aux_leaf_signer.go 3 43.43%
commitment/tap.go 3 84.09%
tapdb/universe.go 4 80.91%
universe/interface.go 12 51.95%
Totals Coverage Status
Change from base Build 12992630782: 0.01%
Covered Lines: 26760
Relevant Lines: 65703

💛 - Coveralls

@gijswijs
Copy link
Contributor

The Rewrap extension in combination with editor rulers is a godsend in vscode.

@lencap
Copy link
Author

lencap commented Jan 28, 2025

Thank for the PR.

Line length linter might fail.

Modified.
Please review again.

@lencap
Copy link
Author

lencap commented Jan 28, 2025

The Rewrap extension in combination with editor rulers is a godsend in vscode.

Thanks!

@ffranr ffranr self-requested a review January 28, 2025 12:54
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should resolve all function name and documentation mismatches in the repository. Addressing all discrepancies in a single commit helps avoid fragmentation across multiple commits and reduces the need for additional PR reviews for similar changes in the future.

Ideally, our linter will catch any new instances of such mismatches going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

4 participants