RPC: Remove anchor_txid from AnchorInfo
#663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
commented
Nov 8, 2023
itest/assertions.go
Outdated
| @@ -69,9 +70,12 @@ func AssetAnchorCheck(txid, blockHash chainhash.Hash) AssetCheck { | |||
| return fmt.Errorf("asset is missing chain anchor field") | |||
| } | |||
|
|
|||
| if a.ChainAnchor.AnchorTxid != txid.String() { | |||
| anchorTxid := | |||
| strings.Split(a.ChainAnchor.AnchorOutpoint, ":")[0] | |||
There was a problem hiding this comment.
Since the txid info was duplicate I now retrieve it by splitting the outpoint string
There was a problem hiding this comment.
I think you should use wire.NewOutPointFromString here.
There was a problem hiding this comment.
Good call, is the hash reversed in the raw outpoint string?
There was a problem hiding this comment.
Yes, the outpoint string consists of the txid and the vout index. The txid in the outpoint string is a hex encoding of the byte reversed hash.
|
There was a flake on a batch mint assets test, kicked it and passed, just flagging |
ffranr
requested changes
Nov 8, 2023
itest/assertions.go
Outdated
| @@ -69,9 +70,12 @@ func AssetAnchorCheck(txid, blockHash chainhash.Hash) AssetCheck { | |||
| return fmt.Errorf("asset is missing chain anchor field") | |||
| } | |||
|
|
|||
| if a.ChainAnchor.AnchorTxid != txid.String() { | |||
| anchorTxid := | |||
| strings.Split(a.ChainAnchor.AnchorOutpoint, ":")[0] | |||
There was a problem hiding this comment.
I think you should use wire.NewOutPointFromString here.
GeorgeTsagk
force-pushed
the
rpc-remove-anchor-txid
branch
from
b45fa51 to
8f7b0c1
Compare
ffranr
requested changes
Nov 8, 2023
GeorgeTsagk
force-pushed
the
rpc-remove-anchor-txid
branch
from
8f7b0c1 to
da6dcea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654