Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: add assetCollector for asset related metrics #664

Closed

Conversation

calvinrzachman
Copy link
Contributor

@calvinrzachman calvinrzachman commented Nov 9, 2023

Enable custom metric for # of minted assets. In the future we will expand this to include additional metrics of interest.

There seems to be some change to the universe stats RPC, upon which the reporting of # of minted assets presently relies. The RPC will not reflect recent changes immediately, but does seem to eventually become consistent.

/ # tapcli --network=regtest --tapddir=/data universe stats
{
    "num_total_assets": "0",
    "num_total_groups": "0",
    "num_total_syncs": "0",
    "num_total_proofs": "0"
}
... some time later
/ # tapcli --network=regtest --tapddir=/data universe stats
{
    "num_total_assets": "8",
    "num_total_groups": "8",
    "num_total_syncs": "0",
    "num_total_proofs": "466"
}

NOTE: This is more or less a mirror of how subasta sets things up.

TODO:

  • Check into whether there have been any changes to the functionality of the universe stats RPC and whether a new approach will need to be taken here.

Partially Addresses: https://github.com/lightninglabs/lightning-infra/issues/990

We will equip tapd to export metrics on the # of assets minted
and transferred.
We take care to ensure that all metric groups use
the same custom prometheus registry. This results
in all metrics being exposed on the same HTTP endpoint.
@GeorgeTsagk GeorgeTsagk self-assigned this Nov 28, 2023
@GeorgeTsagk
Copy link
Member

Closing this in favor of #716

@GeorgeTsagk GeorgeTsagk closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants