-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: use ephemeral multiverse trees for sparse sync #742
Draft
guggero
wants to merge
10
commits into
main
Choose a base branch
from
ephemeral-multiverse-trees
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll want to use the new MultiverseRoots RPC as an optimized way to find out what roots need to be synced during the normal universe sync. So we need to allow access to that RPC without a macaroon as we do for the previously used AssetRoots call.
This is a first optimization to make some of the queries around the multiverse faster. We create an index for all the fieds that appear either in a JOIN or WHERE clause in our multiverse queries.
Here are some of the benchmark runs and improvements from this PR. LegendEverything is in nanoseconds.
SQLite
No optimizations
Database indexes
Database indexes + cache
Postgres
No optimizations
Database indexes
Database indexes + cache
|
guggero
force-pushed
the
ephemeral-multiverse-trees
branch
from
December 18, 2023 18:21
f007f14
to
6fd49e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621.
This PR first optimizes the
FetchLeaves
call of the multiverse database by adding database-level indexes and caches.In the second part we then start using ephemeral multiverse roots to find out what universes need to be synced.
TODO: