tapdb+mssmt: update mssmt unit tests to run against all registered db backends

tapdb/postgres.go

@@ -173,6 +173,25 @@ func NewTestPostgresDB(t *testing.T) *PostgresStore {
 	return store
 }
 
+// NewPostgresDB is a helper function that creates a Postgres database for
+// testing.
+func NewPostgresDB() (*PostgresStore, error) {
+	var t testing.T
+	sqlFixture := NewTestPgFixture(&t, DefaultPostgresFixtureLifetime, true)
+	if t.Failed() {
+		return nil, fmt.Errorf("unable to make postgres db")
+	}
+
+	store, err := NewPostgresStore(sqlFixture.GetConfig())
+	if err != nil {
+		return nil, err
+	}
+
+	// sqlFixture.TearDown(t)
+
+	return store, nil
+}
+
 // NewTestPostgresDBWithVersion is a helper function that creates a Postgres
 // database for testing and migrates it to the given version.
 func NewTestPostgresDBWithVersion(t *testing.T, version uint) *PostgresStore {

tapdb/sqlite.go

@@ -196,6 +196,20 @@ func NewTestSqliteDbHandleFromPath(t *testing.T, dbPath string) *SqliteStore {
 	return sqlDB
 }
 
+// NewSqliteDbHandleFromPath is a helper function that creates a SQLite
+// database handle given a database file path.
+func NewSqliteDbHandleFromPath(dbPath string) (*SqliteStore, error) {
+	sqlDB, err := NewSqliteStore(&SqliteConfig{
+		DatabaseFileName: dbPath,
+		SkipMigrations:   false,
+	})
+	if err != nil {
+		return nil, err
+	}
+
+	return sqlDB, nil
+}
+
 // NewTestSqliteDBWithVersion is a helper function that creates an SQLite
 // database for testing and migrates it to the given version.
 func NewTestSqliteDBWithVersion(t *testing.T, version uint) *SqliteStore {

tapdb/sqlutils_test.go

@@ -280,13 +280,6 @@ func newDbHandleFromDb(db *BaseDB) *DbHandler {
 	}
 }
 
-// NewDbHandleFromPath creates a new database store handle given a database file
-// path.
-func NewDbHandleFromPath(t *testing.T, dbPath string) *DbHandler {
-	db := NewTestDbHandleFromPath(t, dbPath)
-	return newDbHandleFromDb(db.BaseDB)
-}
-
 // NewDbHandle creates a new database store handle.
 func NewDbHandle(t *testing.T) *DbHandler {
 	// Create a new test database with the default database file path.

tapdb/test_postgres.go

@@ -6,17 +6,26 @@ import (
 	"testing"
 )
 
+const activeTestDB = "postgres"
+
 // NewTestDB is a helper function that creates a Postgres database for testing.
 func NewTestDB(t *testing.T) *PostgresStore {
 	return NewTestPostgresDB(t)
 }
 
 // NewTestDbHandleFromPath is a helper function that creates a new handle to an
-// existing SQLite database for testing.
+// existing Postgres database for testing.
 func NewTestDbHandleFromPath(t *testing.T, dbPath string) *PostgresStore {
 	return NewTestPostgresDB(t)
 }
 
+// NewDbHandleFromPath is a helper function that creates a new handle to an
+// existing Postgres database for testing. This version returns an error if an
+// an issue is hit during init.
+func NewDbHandleFromPath(dbPath string) (*PostgresStore, error) {
+	return NewPostgresDB()
+}
+
 // NewTestDBWithVersion is a helper function that creates a Postgres database
 // for testing and migrates it to the given version.
 func NewTestDBWithVersion(t *testing.T, version uint) *PostgresStore {

tapdb/test_sqlite.go

@@ -6,6 +6,8 @@ import (
 	"testing"
 )
 
+const activeTestDB = "sqlite3"
+
 // NewTestDB is a helper function that creates an SQLite database for testing.
 func NewTestDB(t *testing.T) *SqliteStore {
 	return NewTestSqliteDB(t)
@@ -17,6 +19,13 @@ func NewTestDbHandleFromPath(t *testing.T, dbPath string) *SqliteStore {
 	return NewTestSqliteDbHandleFromPath(t, dbPath)
 }
 
+// NewDbHandleFromPath is a helper function that creates a new handle to an
+// existing SQLite database for testing. This version returns an error if an
+// issue is encountered during init.
+func NewDbHandleFromPath(dbPath string) (*SqliteStore, error) {
+	return NewSqliteDbHandleFromPath(dbPath)
+}
+
 // NewTestDBWithVersion is a helper function that creates an SQLite database for
 // testing and migrates it to the given version.
 func NewTestDBWithVersion(t *testing.T, version uint) *SqliteStore {