Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTelCol exporter names used by metrics/trace SDKs #480

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jun 16, 2023

Description: This modifies the telemetry output by the SDKs regarding their export pipelines.

Link to tracking Issue:
Relates to f5/otel-arrow-adapter#119

Testing: n/a

@jmacd jmacd requested a review from moh-osman3 June 16, 2023 19:53
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (6ed7e08) 89.13% compared to head (bb0912b) 89.13%.

❗ Current head bb0912b differs from pull request most recent head f255ed7. Consider uploading reports for the commit f255ed7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          61       61           
  Lines        3581     3581           
=======================================
  Hits         3192     3192           
  Misses        302      302           
  Partials       87       87           
Impacted Files Coverage Δ
...htstep/sdk/metric/exporters/otlp/otelcol/client.go 74.52% <66.66%> (ø)
...ghtstep/sdk/trace/exporters/otlp/otelcol/client.go 68.36% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmacd jmacd merged commit d4fc8b9 into main Jun 16, 2023
@jmacd jmacd deleted the jmacd/update_names branch June 16, 2023 20:44
@jmacd jmacd mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants