-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] chore: remove backup #289
[3.x] chore: remove backup #289
Conversation
3b9e75d
to
28a9703
Compare
7d3874b
to
45feee5
Compare
45feee5
to
826a8a6
Compare
826a8a6
to
e11fb1d
Compare
@alexislefebvre removing the SqliteDatabaseBackup.php makes our tests at least 10x slower. It appeared to be working before, was it just the MySQL backup that wasn't? Would you be willing to restore this functionality (I can do the PR if needed) or is there another configuration option we should be setting to avoid needed to build the Sqlite database with every test? |
@jrjohnson Thanks for the feedback. Is it fixtures loading and/or the tests execution that is 10x slower? You can revert to 2.9.0 to avoid this issue while we assess the situation. To avoid creating the schema with every test: use the |
I'm not sure what is causing the slowdown, I'm just looking at a test run that has been running for almost 3 hours and is less than half way done. The only change was upgrading and removing that config. We'd generally expect all tests to run in less than an hour, for comparison this one, also from this morning took 55 minutes. I'll try adding the |
Just adding a note on progress: I'm unable to get test to run at all using the |
@alexislefebvre - just to echo what @jrjohnson said: we're keen to keep this functionality, it works seamlessly for us and has done for many years. Unfortunately our repo is private so I can't share details, but happy to help where we can. |
same here. Glad to hear that you work on bringing back |
Backups have been reverted on an alpha release, please see here to test it and give feedback: |
A new stable release, that support backups, has been released: https://github.com/liip/LiipTestFixturesBundle/releases/tag/3.1.0 |
Thanks @alexislefebvre, we updated, looks great! |
Ditto, thank you @alexislefebvre. We've just merged it into our prod app. Thanks! |
See: