-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class configuration functionality instead of php files #122
base: main
Are you sure you want to change the base?
Add class configuration functionality instead of php files #122
Conversation
generally: a pull request should be one feature, so php unit should be one, class config options another, however this isn't too bad with the phpunit stuff as thats just a minor change. |
@ppetermann For PHPUnit see #121 Imho the php version support pre 5.6 should be dropped. |
@sseidelmann As you can see RMT is an old project that deserve some care... Anyway thanks for all your efforts so far! If I get it right we need one more PR, #124, from @acrobat to have a better PHPUnit setup before been able to merge this final PR. Right? |
I agree to drop at least php 5.3 .. imho 5.5. should only be drop if creates a lot of hackery |
@lsmith77 @jeanmonod When merge the PR #124 I will check the code again and give some updates later. |
#124 is merged |
Any news on this? I really like the change. |
@sseidelmann as #124 is merged, do you want to try to merge master into your branch an see if the tests are still broken? |
Here is a configuration enhancement for passing classes in configuration files instead of files. It will look like:
version-generator: "Liip\\RMT\\Tests\\Unit\\Config\\ExternalClasses\\CustomVersionPersister"
Now you can use your classes with your own composer autoloading.