Dependency upgrades #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates phpSmug to use a newer version of Guzzle and PHPUnit. The changes will hopefully eliminate some deprecation warning messages when the library is used with newer PHP versions.
In implementing these changes, some issues arose. For example, two of the unit tests (
shouldGetPrivateImageWithSignedUrlandshouldFailToGetPrivateImage) are currently either failing or being flagged as 'risky' because the behaviour of the system doesn't match the test expectations. This may be due to a recent change in URL signing behaviour in the SmugMug API.I refactored the client tests to add NICKNAME and FOLDER environment variables to make it easier for folks to run the test against their own accounts.