Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website gha.md: job env variable sets LIMA_VERSION #3165

Conversation

msgilligan
Copy link
Contributor

  1. Fixes the cache action which was resolving ${{ env.LIMA_VERSION }} to an empty string.

  2. Makes the build more functional/reproducible by not getting LIMA_VERSION from an external source.

@msgilligan
Copy link
Contributor Author

msgilligan commented Jan 27, 2025

I have made and tested the above change here:
nixos-lima/nixos-lima-config-sample@2e5bd7c

You can see the output from the job before the change here:

Run actions/cache@v4
  with:
    path: ~/.cache/lima
    key: lima-
    enableCrossOsArchive: false
    fail-on-cache-miss: false
    lookup-only: false
    save-always: false
Cache not found for input keys: lima-

And after the change here:

Run actions/cache@v4
  with:
    path: ~/.cache/lima
    key: lima-v1.0.4
    enableCrossOsArchive: false
    fail-on-cache-miss: false
    lookup-only: false
    save-always: false
  env:
    LIMA_VERSION: v1.0.4
Cache not found for input keys: lima-v1.0.4

Here is the successful job:
https://github.com/nixos-lima/nixos-lima-config-sample/actions/runs/12997768752/job/36249456914

@msgilligan msgilligan force-pushed the msgilligan/website-gha-lima-version-cache-fix branch from 694735c to 6c61a62 Compare January 27, 2025 21:04
@AkihiroSuda AkihiroSuda added the documentation Improvements or additions to documentation label Jan 28, 2025
Fixes the `cache` action which was resolving `${{ env.LIMA_VERSION }}`
to an empty string.

Signed-off-by: Sean Gilligan <[email protected]>
@msgilligan
Copy link
Contributor Author

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 5264419 into lima-vm:master Jan 29, 2025
9 checks passed
@AkihiroSuda AkihiroSuda added this to the v1.1.0 (tentative) milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants