Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-2868 Fix composer bold option toggle #2898

Merged
merged 1 commit into from
Jun 19, 2024
Merged

TF-2868 Fix composer bold option toggle #2898

merged 1 commit into from
Jun 19, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented May 29, 2024

Issue

#2868

Root cause

  • Side effect of fixing memory leak error in PR Fix composer memory leak html-editor-enhanced#34. Resulting in ToolbarWidget not being created, causing toolbar object in HtmlEditorController to be null. And onChangeSelection is not listened to.

Solution

Resolved

Screen.Recording.2024-05-29.at.11.57.39.mov

tddang-linagora
tddang-linagora reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@tddang-linagora tddang-linagora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update toolbarType: ToolbarType.hide in web_editor_widget.dart instead?

@dab246
Copy link
Member Author

dab246 commented May 30, 2024

Should we update toolbarType: ToolbarType.hide in web_editor_widget.dart instead?

Are not. If you do so the default toolbarwidget will be rendered. But we don't want that

@hoangdat
Copy link
Member

should be move to refactor branch also

@hoangdat hoangdat mentioned this pull request Jun 11, 2024
Closed
@dab246 dab246 changed the base branch from master to refactor June 11, 2024 09:25
@dab246 dab246 force-pushed the fixbug/tf-2868-composer-bold-option-toggle branch from aeec009 to c8bffff Compare June 11, 2024 09:30
@dab246
Copy link
Member Author

dab246 commented Jun 11, 2024

should be move to refactor branch also

Done

@dab246 dab246 force-pushed the fixbug/tf-2868-composer-bold-option-toggle branch from c8bffff to 4ea3f5e Compare June 11, 2024 11:48
@hoangdat
Copy link
Member

please update to use cnb_supported in pubspec.

@hoangdat
Copy link
Member

hoangdat commented Jun 17, 2024 •
edited
Loading

  • Chrome
  • Edge
  • Firefox
  • Safari

@dab246 dab246 force-pushed the fixbug/tf-2868-composer-bold-option-toggle branch from 4ea3f5e to 77128c0 Compare June 18, 2024 09:57
@dab246
Copy link
Member Author

dab246 commented Jun 18, 2024

please update to use cnb_supported in pubspec.

Done

@hoangdat
Copy link
Member

hoangdat commented Jun 18, 2024 •
edited
Loading

@dab246
Copy link
Member Author

dab246 commented Jun 19, 2024 •
edited
Loading

This PR only fix error on Web. With mobile fixed at #2795

@hoangdat hoangdat merged commit 640b100 into refactor Jun 19, 2024
21 checks passed
@hoangdat hoangdat deleted the fixbug/tf-2868-composer-bold-option-toggle branch November 6, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat hoangdat approved these changes

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @hoangdat @tddang-linagora